sven/netbox-plugin-dns-bridge
0
0 Fork 0
Code Actions Packages Releases Wiki Activity

Rename _getZoneFromNB to _get_zone_from_nb

Browse Source 
_getZoneFromNB was the only camelCase function in the codebase,
inconsistent with the snake_case convention used everywhere else.
Rename it and update its callers and the adjacent comment.

Pure rename, no behavior change.
This commit is contained in:
sven authored and Sven Luthi committed 2026-08-11 11:11:07 +02:00
1 parent c6c7cf70ec
commit ba1b03106b
1 file changed
+3 -3
Download Patch File Download Diff File Expand all files Collapse all files
netbox_dns_bridge/request_handler.py
+3 -3
View File
@@ -28,8 +28,8 @@ class DNSBaseRequestHandler(socketserver.BaseRequestHandler):
self.RESERVED_TSIG = 300 self.RESERVED_TSIG = 300
super().__init__(request, client_address, server) super().__init__(request, client_address, server)
# _getZoneFromNB rewritten # _get_zone_from_nb rewritten
def _getZoneFromNB(self, zone_name, view_name) -> dns.zone.Zone: def _get_zone_from_nb(self, zone_name, view_name) -> dns.zone.Zone:
# Find the zone # Find the zone
try: try:
nb_zone = Zone.objects.get( nb_zone = Zone.objects.get(
@@ -361,7 +361,7 @@ class DNSBaseRequestHandler(socketserver.BaseRequestHandler):
if dname == "catz" or dname == f"{nb_view.name}.catz": if dname == "catz" or dname == f"{nb_view.name}.catz":
zone = catzm.create_zone(dname, nb_view.name) zone = catzm.create_zone(dname, nb_view.name)
else: else:
zone = self._getZoneFromNB(dname, nb_view.name) zone = self._get_zone_from_nb(dname, nb_view.name)
# When zone was not found, let client know # When zone was not found, let client know
if not zone: if not zone:
LOGGER.warning(f"Zone {dname} not found in view {nb_view.name}") LOGGER.warning(f"Zone {dname} not found in view {nb_view.name}")