From ba1b03106b7f69034a2315f26b1ca5f35ecd7160 Mon Sep 17 00:00:00 2001 From: Sven Luethi Date: Tue, 11 Aug 2026 10:55:40 +0200 Subject: [PATCH] Rename _getZoneFromNB to _get_zone_from_nb _getZoneFromNB was the only camelCase function in the codebase, inconsistent with the snake_case convention used everywhere else. Rename it and update its callers and the adjacent comment. Pure rename, no behavior change. --- netbox_dns_bridge/request_handler.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/netbox_dns_bridge/request_handler.py b/netbox_dns_bridge/request_handler.py index 126ad49..fda3cdc 100644 --- a/netbox_dns_bridge/request_handler.py +++ b/netbox_dns_bridge/request_handler.py @@ -28,8 +28,8 @@ class DNSBaseRequestHandler(socketserver.BaseRequestHandler): self.RESERVED_TSIG = 300 super().__init__(request, client_address, server) - # _getZoneFromNB rewritten - def _getZoneFromNB(self, zone_name, view_name) -> dns.zone.Zone: + # _get_zone_from_nb rewritten + def _get_zone_from_nb(self, zone_name, view_name) -> dns.zone.Zone: # Find the zone try: nb_zone = Zone.objects.get( @@ -361,7 +361,7 @@ class DNSBaseRequestHandler(socketserver.BaseRequestHandler): if dname == "catz" or dname == f"{nb_view.name}.catz": zone = catzm.create_zone(dname, nb_view.name) else: - zone = self._getZoneFromNB(dname, nb_view.name) + zone = self._get_zone_from_nb(dname, nb_view.name) # When zone was not found, let client know if not zone: LOGGER.warning(f"Zone {dname} not found in view {nb_view.name}")