modified: src/netbox_plugin_bind_provisioner/__init__.py

modified:   src/netbox_plugin_bind_provisioner/management/commands/bind-transfer-endpoint.py
Improve TXT record formating.

src/netbox_plugin_bind_provisioner/__init__.py

@@ -5,7 +5,7 @@ from django.utils.translation import gettext_lazy as _
 from django.dispatch import receiver
 from django.conf import settings
 
-__version__ = "1.0.1"
+__version__ = "1.0.3"
 
 logger = logging.getLogger(__name__)
 

src/netbox_plugin_bind_provisioner/management/commands/bind-transfer-endpoint.py

@@ -1,6 +1,7 @@
 import logging
 import socketserver
 import os
+#import re
 import threading
 import dns.query
 import dns.message
@@ -246,21 +247,26 @@ class DNSBaseRequestHandler(socketserver.BaseRequestHandler):
             # If the record has no TTL, use the zone default
             ttl = record.ttl or nb_zone.default_ttl
 
-            # Apply special quoting for TXT records to stop tokanizer
+            # Apply quoting for TXT records to stop tokanizer
             # from cutting it up:
+            value = record.value
             if rdtype == dns.rdatatype.TXT:
-                if len(record.value) <= 255:
+                if value.startswith('"') and value.endswith('"'):
-                    record_value = f'"{record.value}"'
+                    value = value[1:-1].replace('" "', '').replace('"', '\"')
+
+                if len(value) > 255:
+                    # This is a bug fix for netbox. If netbox allowed for
+                    # an unquoted value to be larger then 255 characters,
+                    # it misunderstood everything behind a ; as a comment.
+                    chunks = ['"{}"'.format(value[i:i+255]) for i in range(0, len(value), 255)]
+                    value = " ".join(chunks)
                 else:
-                    chunks = ['"{}"'.format(record.value[i:i+255]) for i in range(0, len(record.value), 255)]
+                    value = f'"{value}"'
-                    record_value = " ".join(chunks)
-            else:
-                record_value = record.value
 
             rdata = dns.rdata.from_text(
                 dns.rdataclass.IN,
                 rdtype,
-                record_value, #asd
+                value,
                 relativize=False,
                 origin=zone.origin,
             )