to DB driven to permit user modification:
modified: netbox_dns_bridge/models.py
Add 4 cols for values.
modified: netbox_dns_bridge/migrations/0003_catalogzone_and_per_zone_identifier.py
Adjust migration. This expects that the last migration the user has is 0002 (<=v1.5.8)
modified: netbox_dns_bridge/jobs/notify.py
modified: netbox_dns_bridge/management/commands/dns_transfer_endpoint/catalog_zone_manager.py
Update to use new db values for SOA creation.
Change UI to permit editing for SOA values and disable member identifier editing.
modified: netbox_dns_bridge/forms.py
modified: netbox_dns_bridge/navigation.py
new file: netbox_dns_bridge/templates/netbox_dns_bridge/catalog_zone_edit.html
new file: netbox_dns_bridge/templates/netbox_dns_bridge/catalog_zone_list.html
new file: netbox_dns_bridge/templates/netbox_dns_bridge/catalog_zone_members.html
deleted: netbox_dns_bridge/templates/netbox_dns_bridge/catz_overview.html
modified: netbox_dns_bridge/tables.py
modified: netbox_dns_bridge/urls.py
modified: netbox_dns_bridge/views.py
modified: netbox_dns_bridge/filtersets.py
AI created/modified: Left the UI update to the LLM.
modified: netbox_dns_bridge/tests/test_catalog_zone_manager.py
modified: netbox_dns_bridge/tests/test_models.py
modified: netbox_dns_bridge/tests/test_notify.py
modified: netbox_dns_bridge/tests/test_views.py
AI created/modified: Updating tests
deleted: netbox_dns_bridge/migrations/0003_integerkeyvaluesetting_key_unique.py
Migration 3 not required since model is being replaced anyway. Removed.
Track the catalog zone SOA serial per view instead of a single global value.
The new CatalogZone model has a 1:1 FK to netbox_dns.models.View and its own
soa_serial field; each view's catalog zone now increments independently. The
existing global serial is preserved during migration by copying it into every
view's new CatalogZone row.
Change CatalogZoneMemberIdentifier.name from globally unique to unique per
catalog zone (UniqueConstraint(name, catalog_zone)) and add a catalog_zone FK
to enforce it.
Remove the dns-settings management command, which was a generic interface over
the now-removed IntegerKeyValueSetting model.
Increment both catalog zone serials when a zone moves between views: the old
view's catalog zone loses a member and the new view's gains one, so both must
be bumped. Also refresh the member identifier's catalog_zone FK on a view move
so it does not go stale. The pre_save handler now captures _old_view_id and the
post_save handler detects view changes, increments the old view's serial inside
on_commit (before the new view's), and re-creates the identifier.
AI generated, code manually verified.
IntegerKeyValueSetting is used as a singleton-style key/value store:
callers do get(key=...) and get_or_create(key=..., ...) and assume at
most one row per key. The model, however, did not enforce uniqueness on
the key field, so nothing prevented duplicate rows at the database
level.
This was a real race for _create_soa_rdataset in catalog_zone_manager,
which calls get_or_create without select_for_update (unlike
increment_soa_serial, which does take a lock). Two concurrent AXFR
queries for a catalog zone could both pass the get_or_create existence
check and both insert a row for key='catalog-zone-soa-serial'. Every
subsequent IntegerKeyValueSetting.objects.get(key=...) call would then
raise MultipleObjectsReturned, breaking catalog-zone SOA rendering and
serial increments.
Add unique=True to the key CharField and ship migration 0003 to enforce
the invariant at the database level. Existing deployments are assumed to
have clean state (no duplicate keys); if duplicates exist, the migration
should be preceded by manual deduplication.
Remove unneeded definition.
modified: MANIFEST.in
Correct path
new file: netbox_dns_bridge/migrations/__init__.py
Fixes missing migration.
new file: netbox_dns_bridge/management/__init__.py
new file: netbox_dns_bridge/management/commands/__init__.py
Just in case
Fix paths after restructuring
renamed: netbox_dns_bridge/management/commands/export-dns-zone.py -> netbox_dns_bridge/management/commands/dns-export-zone.py
renamed: netbox_dns_bridge/management/commands/export-all-dns-zones.py -> netbox_dns_bridge/management/commands/dns-export-zones.py
Unify command naming scheme
new file: netbox_dns_bridge/migrations/0001_initial.py
Adds the missing migration. Since the plugin was renamed this is also an opportunity to merge all changes into a single migration.
renamed: netbox_dns_bridge/service/transfer/catalog_zone_manager.py -> netbox_dns_bridge/catalog_zone_manager.py
renamed: netbox_dns_bridge/service/transfer/dns_server.py -> netbox_dns_bridge/dns_server.py
new file: netbox_dns_bridge/management/commands/dns-settings.py
modified: netbox_dns_bridge/management/commands/dns-transfer-endpoint.py
renamed: netbox_dns_bridge/service/transfer/request_handler.py -> netbox_dns_bridge/request_handler.py
deleted: netbox_dns_bridge/service/transfer/__init__.py
Another restructure to simplify code re-use. New command dns-settings added to allow setting of catalog zone serial.
This will be needed to migrate from previous versions.
sven
Sven Luethi