From e8450c90da7941b5bb07019772d3e86b84da8065 Mon Sep 17 00:00:00 2001 From: Sven Luethi Date: Fri, 9 Jan 2026 02:59:36 +0100 Subject: [PATCH] modified: README.md modified: src/netbox_plugin_bind_provisioner/management/commands/bind-transfer-endpoint.py Remove code and description that imported old catz serials from flat files that were used before switch to DB model. Code and docs no longer applicable so removed. --- README.md | 1 - .../commands/bind-transfer-endpoint.py | 25 +++---------------- 2 files changed, 3 insertions(+), 23 deletions(-) diff --git a/README.md b/README.md index d518aea..de0dc26 100644 --- a/README.md +++ b/README.md @@ -48,7 +48,6 @@ Parameter | Description ### Plugin settings Setting | Description --------------------| --------------------------------------------------------- -catalog_serial_file | !!!NO LONGER USED!!! Replaced by DB entry. tsig_keys | Maps a TSIG Key to be used for each view. ## Installation guide diff --git a/src/netbox_plugin_bind_provisioner/management/commands/bind-transfer-endpoint.py b/src/netbox_plugin_bind_provisioner/management/commands/bind-transfer-endpoint.py index 758beaa..f5199e5 100644 --- a/src/netbox_plugin_bind_provisioner/management/commands/bind-transfer-endpoint.py +++ b/src/netbox_plugin_bind_provisioner/management/commands/bind-transfer-endpoint.py @@ -194,23 +194,6 @@ class CatalogZone: return zone - @classmethod - def importLegacySerialFile(cls, file_path): - if os.path.exists(file_path): - try: - with open(file_path, "r") as f: - serial = int(f.read().strip()) - cls._serial_obj.value = int(serial) - cls._serial_obj.save() - logger.info( - f"Legacy catalog serial file {file_path} imported into database and file removed. Serial is now {serial}" - ) - os.remove(file_path) - except OSError as e: - logger.error( - f"Failed to import catalog zone serial from legacy file {file_path}" - ) - class DNSBaseRequestHandler(socketserver.BaseRequestHandler): # getZoneFromNB rewritten @@ -715,18 +698,15 @@ class Command(BaseCommand): port = options["port"] address = options["address"] CatalogZone.initSerial() + # Initialize settings self.loadSettings() - # self.loadCatalogZoneSettings() self.loadTSIGKeySettings() - # Following is temporary. Function and invocation can be deleted once v1.0 is reached. - serial_file = self.settings.get("catalog_serial_file", None) - if serial_file: - CatalogZone.importLegacySerialFile(serial_file) udp_server = UDPDNSServer( (address, port), UDPRequestHandler, self.keyring, self.tsig_view_map ) + tcp_server = TCPDNSServer( (address, port), TCPRequestHandler, self.keyring, self.tsig_view_map ) @@ -738,6 +718,7 @@ class Command(BaseCommand): udp_thread = threading.Thread( target=run_udp_server, args=(udp_server,), daemon=True ) + udp_thread.start() logger.debug(f"AXFR endpoint listening on {address} tcp/{port}")