Replace global IntegerKeyValueSetting with per-view CatalogZone model

Track the catalog zone SOA serial per view instead of a single global value.
The new CatalogZone model has a 1:1 FK to netbox_dns.models.View and its own
soa_serial field; each view's catalog zone now increments independently. The
existing global serial is preserved during migration by copying it into every
view's new CatalogZone row.

Change CatalogZoneMemberIdentifier.name from globally unique to unique per
catalog zone (UniqueConstraint(name, catalog_zone)) and add a catalog_zone FK
to enforce it.

Remove the dns-settings management command, which was a generic interface over
the now-removed IntegerKeyValueSetting model.

Increment both catalog zone serials when a zone moves between views: the old
view's catalog zone loses a member and the new view's gains one, so both must
be bumped. Also refresh the member identifier's catalog_zone FK on a view move
so it does not go stale. The pre_save handler now captures _old_view_id and the
post_save handler detects view changes, increments the old view's serial inside
on_commit (before the new view's), and re-creates the identifier.

AI generated, code manually verified.
This commit is contained in:
sven authored and Sven Luthi committed 2026-09-02 12:01:54 +02:00
1 parent e8762bf807
commit 6be7359c27
9 files changed
+263 -96

No files matched your search

+4 -5
View File
@@ -8,7 +8,7 @@ from netbox.views.generic import ObjectListView
from .filtersets import ZoneFilterSet
from .forms import CatalogZoneFilterForm
from .models import IntegerKeyValueSetting, SeenTransferClients
from .models import CatalogZone, SeenTransferClients
from .tables import CatalogZoneTable
@@ -27,10 +27,9 @@ class CatzOverviewView(ObjectListView):
def get_extra_context(self, request):
context = super().get_extra_context(request)
soa_serial_obj = IntegerKeyValueSetting.objects.filter(
key="catalog-zone-soa-serial"
).first()
context["soa_serial"] = soa_serial_obj.value if soa_serial_obj else None
context["catalog_zones"] = CatalogZone.objects.select_related(
"view"
).order_by("view__name")
return context