Registration working

software/database/sqlite.php

@@ -98,23 +98,34 @@ class DB implements DBIface {
     }
 
 public function updateDevice($id, $deviceData) {
-        $sql = "
+    // Start building the SQL query
-            UPDATE devices
+    $sql = "UPDATE devices SET ";
-            SET id = :id,
+    
-                mac_address = :mac_address,
+    // Add the columns to be updated
-                ip_address = :ip_address,
+    $columns = [];
-                ip_address_seen = :ip_address_seen,
+    foreach ($deviceData as $column => $value) {
-                firmware_version = :firmware_version,
+        $columns[] = "$column = :$column";
-                temperature_offset = :temperature_offset,
+    }
-                humidity_offset = :humidity_offset,
+    $sql .= implode(", ", $columns);
-                last_seen = :last_seen
+    
-            WHERE id = :id
+    // Add the WHERE clause based on id
-        ";
+    $sql .= " WHERE id = :id";
+
     try {
+        // Prepare the statement
         $stmt = $this->pdo->prepare($sql);
-            $deviceData['id'] = $id;
+
-            $stmt->execute($deviceData);
+        // Bind the parameters for the columns to be updated
-            return $stmt->rowCount();
+        foreach ($deviceData as $column => $value) {
+            $stmt->bindValue(":$column", $value);
+        }
+
+        // Bind the parameter for the id
+        $stmt->bindValue(":id", $id, PDO::PARAM_INT);
+
+        // Execute the statement
+        return $stmt->execute();
+
         } catch (PDOException $e) {
             die("Error updating device: " . $e->getMessage());
         }

software/device-api.php

@@ -27,38 +27,18 @@ $router->post('/api/config', function($req) use($db) {
        !valid($msg,'ip_address',         '/^[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*\.[0-9][0-9]*$/i') ||
        !valid($msg,'firmware_version',   '/^[0-9]+$/') ||
        !valid($msg,'temperature_offset', '/^[0-9]+\.*[0-9]*$/') ||
-       !valid($msg,'humidity_offset',    '/^[0-9]+\.*[0-9]*$/')
+       !valid($msg,'humidity_offset',    '/^[0-9]+\.*[0-9]*$/') ||
+       !valid($msg,'id','/^[0-9]+$/')
     ) {
         echo '{"error_message": "Field verification failed."}';
         http_response_code(400);
         return;
     }
 
-    // If device is already registered (it sends an ID) then figure out what values changed and send those back for the device to re-configure itself.
+    $deviceData = $msg['id'] == 0 ?  null : $db->getDeviceByID($msg['id']);
-    else if(valid($msg,'id','/^[0-9]+$/')) {
+    // If device is not registered yet, register...
-        $deviceData = $db->getDeviceByID($msg['id']);
-        // If device is not registered yet...
     if($deviceData == null) {
-            echo '{"error_message": "Device by that ID not found."}';
-            http_response_code(400);
-            return;
-        }
-        // Return stored device data so device may update its settings.
-        echo json_encode($deviceData);
-        // Update database entry based on post data received.
-        $db->updateDevice([
-            'mac_address'        => $msg['mac_address'],
-            'ip_address'         => $msg['ip_address'],
-            'ip_address_seen'    => $_SERVER['REMOTE_ADDR'],
-            'firmware_version'   => $msg['firmware_version'],
-            'last_seen'          => date('Y-m-d H:i:s')
-        ]);
-        http_response_code(200);
-        return;
-    }
-
         // All fields are set and no ID was given. Register new device and return new ID...
-    else {
         $config = [
             'mac_address'        => $msg['mac_address'],
             'ip_address'         => $msg['ip_address'],
@@ -69,9 +49,25 @@ $router->post('/api/config', function($req) use($db) {
             'last_seen'          => date('Y-m-d H:i:s')
         ];
         $deviceID = $db->addDevice($config);
-        echo json_encode(['deviceID' => $deviceID]);
+        $config['deviceID'] = $deviceID;
+        echo json_encode($config);
         http_response_code(200);
+        return;
     }
+    // If device is registered...
+    // Update database entry based on post data received.
+    $db->updateDevice($deviceData['id'],
+    [
+        'mac_address'        => $msg['mac_address'],
+        'ip_address'         => $msg['ip_address'],
+        'ip_address_seen'    => $_SERVER['REMOTE_ADDR'],
+        'firmware_version'   => $msg['firmware_version'],
+        'last_seen'          => date('Y-m-d H:i:s')
+    ]);
+    // Return stored device data so device may update its settings.
+    echo json_encode($deviceData);
+    http_response_code(200);
+    return;
 });
 
 // Device reports temperature back on this endpoint.